Gh104 #106
Open
Gh104 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt for rsync daemon on joiner is busy.
| // written in BE format. This BE detection has failure probability of | ||
| // 1 in 256M. This must be removed after next release. | ||
| wsrep_seqno_t const ret(wsrep_seqno_byteswap(seqno)); | ||
| return (ret > 0x0000000fffffffffLL || ret < WSREP_SEQNO_UNDEFINED ? |
There was a problem hiding this comment.
This looks like a time bomb. It would probably be better to change WSREP_XID_PREFIX and do the byteswap if the stored value has the new format.
There was a problem hiding this comment.
Does WSREP_XID_PREFIX act as a version ID? If so, then indeed it is better.
…XID prefix as a version ID to distinguish which order XID seqno is stored in.
| @@ -317,22 +317,11 @@ trx_sys_print_mysql_binlog_offset(void) | |||
|
|
|||
| #ifdef WITH_WSREP | |||
|
|
|||
| #include <wsrep_xid.h> | |||
There was a problem hiding this comment.
This introduces unnecessary dependency between InnoDB and MySQL/wsrep code. Setting xid->formatID = -1 in code below is enough to indicate that the XID is null, so WSREP_* macros and wsrep_xid_init() don't have to be included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to read/write seqno to XID in a little-endian format.